Skip to content

feat: Support SDK metrics #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 21, 2025
Merged

feat: Support SDK metrics #136

merged 7 commits into from
Jul 21, 2025

Conversation

khvn26
Copy link
Member

@khvn26 khvn26 commented Jul 10, 2025 •
edited
Loading

Closes #130.

  • Adds custom User-Agent header value to include the SDK name and version
  • Adds support for optional client application metadata when initialising the Flagsmith client

@khvn26 khvn26 self-assigned this Jul 10, 2025
@github-actions github-actions bot added feature and removed feature labels Jul 10, 2025
@matthewelwell matthewelwell self-requested a review July 11, 2025 08:54
emyller
emyller previously approved these changes Jul 11, 2025
View reviewed changes
Copy link
Contributor

@emyller emyller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with non-blocking comments.

matthewelwell
matthewelwell reviewed Jul 15, 2025
View reviewed changes
@github-actions github-actions bot added feature and removed feature labels Jul 21, 2025
@khvn26 khvn26 force-pushed the feat/sdk-metrics branch from 9be3441 to f0607a1 Compare July 21, 2025 19:03
@github-actions github-actions bot added feature and removed feature labels Jul 21, 2025
@github-actions github-actions bot added feature and removed feature labels Jul 21, 2025
@khvn26 khvn26 requested a review from emyller July 21, 2025 19:10
@github-actions github-actions bot added feature and removed feature labels Jul 21, 2025
@khvn26 khvn26 merged commit 441c46a into main Jul 21, 2025
7 checks passed
@khvn26 khvn26 deleted the feat/sdk-metrics branch July 21, 2025 19:17
@flagsmithdev flagsmithdev mentioned this pull request Jul 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewelwell matthewelwell matthewelwell left review comments

@emyller emyller emyller approved these changes

Assignees

@khvn26 khvn26

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support SDK metrics
3 participants
@khvn26 @emyller @matthewelwell